Make every uploaded ZIP reachable in the mobile file list #5
Loading…
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
On a phone, a collection with three ZIP files reports three parts but exposes only two entries. The status panel obscures the final item.
Acceptance criteria:
Starting owner-requested #5 after reading #14 and all comments. Scope: make every ZIP and its controls reachable on narrow/mobile layouts, retain selection and the status panel while switching entries, and preserve cross-browser monitoring. I will work from current main in an isolated branch, inspect the existing layout, and verify three-file and longer lists with long filenames, touch and keyboard access. Held #12/PR #19 and its checkout remain untouched. No deployment, rebuild/restart of running services, or interruption of uploads/tasks is planned.
Finding: the mobile 360px limit covered the whole sidebar, so expanded upload help could consume the list area and clip the third ZIP. A synthetic 320px regression reproduced this before the fix. Implementation now limits only a labelled native ZIP scroll region, with wrapping names, separate keyboard-accessible selection/removal buttons and 44px touch targets; the mobile status panel follows the rail without overlap. Focused Chromium checks pass for 3/16 ZIPs at 320/390/760/761/1280px, expanded help, actual emulated touch dragging/tapping, keyboard scrolling/Enter/Space/Tab, selection retention and two independent owner sessions through monitoring outage/reconnect. Existing activity/cancellation checks, lint/build and dependency audit pass. The disposable full walkthrough exposed an initial-navigation timing race in its harness before any upload UI checks; I am stabilizing that wait and rerunning it. No deployed services were touched.
jchapman referenced this issue2026-10-27 11:39:09 +00:00
Implemented and published for review in draft PR #24, commit
e274c617aa64ace46a6a53a558de717083f37545, based on main44c36de10d3c4c8a4a72c01750e20bd2e88ab969.Changes:
ui/tests/mobile-file-list.mjsto the CI browser gate and update walkthrough selectors. Stabilize the walkthrough's initial collection-redirect wait before Administration navigation. Document behavior and the remaining installation/device checklist.Checks actually passed:
State/limits: source is committed and pushed, not merged, release-image-published or deployed. Native Forgejo run 23 for this exact commit is waiting. Native AMD64/ARM64 suites and the aggregate release gate remain required; no waiver is claimed. The existing bundle-size advisory remains. Emulated Chromium touch is not physical-device/Safari validation; perform the documented device and actual-instance monitoring checks after coordinated installation. No real photo library or email was used, and no deployed service or active upload/task was interrupted. Held #12/PR #19 and its checkout remain unchanged at
dc6003743056822cca9c4e81fc1f436bc5ac8635.Next handoff: review PR #24, complete native CI, then coordinate idle installation and actual-device/pilot checks. #5 remains open for review; #14 remains the coordination index.
Resuming #5 for owner-requested PR #24 merge readiness after reading #14, #5 and their full comment history. The published feature is already complete; I am independently reviewing the source/test diff, rerunning focused UI and CI contracts, and checking current main/head ancestry and server merge restrictions. If those checks pass, I will remove the draft marker and merge the reviewed source without force or release-gate changes. Native Forgejo jobs are still waiting; native release validation and actual-device/installation checks remain required separately. No deployment or interruption of running services/uploads/tasks is planned. Held #12/PR #19 remains excluded.
Owner-requested review and merge completed: PR #24 merged into main in
0a47f4f6fc2455dc304df49fa8c45084ff4a2d65, preserving featuree274c617aa64ace46a6a53a558de717083f37545and its branch. #5 was closed by the merge. The earlier keep-open-for-review instruction is superseded by this completed source review and owner-requested merge.Every ZIP now has reachable selection/remove controls within a labelled native scroll region; mobile help grows above it and the wrapped selected status panel follows below. This review independently re-ran UI lint/build, full dependency audit (zero vulnerabilities), mobile-file-list, task-activity, task-email and advanced-import browser suites; all passed. All nine CI policy tests, source/workflow/document contracts and diff/clean-tree checks passed. Fresh synthetic narrow-screen screenshots were inspected. Responsive evidence covers 3/16 ZIPs at 320/390/760/761/1280px, touch dragging/tapping, keyboard scrolling/Enter/Space/Tab, 44px remove controls, selection retention and independent-session monitoring/reconnect. Earlier full disposable container/upload evidence is retained in comment 370; it was not rerun during this source review.
Post-merge verification: main tree
ab083802432b456c4af77d9a8413e706faee2926exactly equals the validated feature tree; both expected parents and feature ancestry are preserved. No conflicts or force merge; no branch-protection or release-gate changes. The original held #12 checkout and draft PR #19 remain unchanged atdc6003743056822cca9c4e81fc1f436bc5ac8635.State/next step: source is merged, not deployed or release-image-published. Final-main native run 24 is waiting. Native AMD64/ARM64 suites and the aggregate release gate remain required before release; the existing bundle-size advisory and physical-device/Safari/actual-instance monitoring checks remain recorded in testing and the installation checklist. Development closure does not waive them. Complete native validation, then coordinate idle installation of matching app/runner/processor images and device/pilot checks. No running service or active upload/task was interrupted. #14 stays open for coordination; #12/PR #19 stays on hold.