Explain preliminary metadata coverage separately from ZIP integrity #18

Merged

jchapman merged 2 commits from codex/issue-6-metadata-coverage into main 2026-10-27 02:13:41 +00:00

Conversation 0 Commits 2 Files changed 12 +410 -111

jchapman commented 2026-10-25 21:09:42 +00:00

Owner

Copy link

The analysis report presented filename matching as a health check, making intact exports look damaged and implying importer outcomes it cannot predict. This separates ZIP integrity from preliminary metadata coverage, explains entry/JSON counts and subset-only timeline/location summaries, and directs users to Immich-Go's own preview and retained diagnostics.

• Report no candidate, ambiguous candidates, and repeated media entries/paths separately. Reject ambiguity across both matching rules instead of selecting a shorter-name fallback; handle uppercase JSON suffixes.
• Recognize all 57 image/video extensions in the pinned importer's baseline and count other file entries. Counts remain ZIP entries, including album representations, rather than unique photos.
• Explain the default-off unmatched-media choice, full ZIP-set processing and the required new preview after an option change. Preserve legacy reports without inventing a missing breakdown; suppress year-1 dates for empty summaries.
• Preserve owner-only analysis access and aggregate-only support reports. Document the limits and the decision to make importer preview results authoritative for importer outcomes.

Validation passed locally on AMD64 Docker Desktop: backend tests/vet with the pinned importer; UI lint and production build; disposable browser/upload-recovery suite including real queued analysis, synthetic ambiguous/repeated/empty/legacy reports, 320/390px report layout, other-user/administrator isolation and support-report privacy; nine CI policy tests and source/documentation contracts; exact pinned-format comparison; source-only secret scan; source gosec/govulncheck and all three image advisory policies with existing baselines unchanged. Source scan: 32 production files, 29 reviewed findings, no suppressions.

Addresses #6; follows #14. Stacked on #15, with codex/issues-10-11-diagnostics as the base so this review contains only #6. Retarget to main after #15 merges. Commit: 9980373bf6d7025f23560f47ede1c9ff74dce1e1.

This is pushed for review, not merged, release-image-published or deployed. Native ARM64/full release CI and a real-library pilot are not claimed. A separate existing header extends 3px beyond 320px; the report fits and the established whole-page 390px check passes. Keep #6 open through review and the coordinated idle deployment/new owner preview; do not interrupt active uploads/tasks.

The analysis report presented filename matching as a health check, making intact exports look damaged and implying importer outcomes it cannot predict. This separates ZIP integrity from preliminary metadata coverage, explains entry/JSON counts and subset-only timeline/location summaries, and directs users to Immich-Go's own preview and retained diagnostics. - Report no candidate, ambiguous candidates, and repeated media entries/paths separately. Reject ambiguity across both matching rules instead of selecting a shorter-name fallback; handle uppercase JSON suffixes. - Recognize all 57 image/video extensions in the pinned importer's baseline and count other file entries. Counts remain ZIP entries, including album representations, rather than unique photos. - Explain the default-off unmatched-media choice, full ZIP-set processing and the required new preview after an option change. Preserve legacy reports without inventing a missing breakdown; suppress year-1 dates for empty summaries. - Preserve owner-only analysis access and aggregate-only support reports. Document the limits and the decision to make importer preview results authoritative for importer outcomes. Validation passed locally on AMD64 Docker Desktop: backend tests/vet with the pinned importer; UI lint and production build; disposable browser/upload-recovery suite including real queued analysis, synthetic ambiguous/repeated/empty/legacy reports, 320/390px report layout, other-user/administrator isolation and support-report privacy; nine CI policy tests and source/documentation contracts; exact pinned-format comparison; source-only secret scan; source gosec/govulncheck and all three image advisory policies with existing baselines unchanged. Source scan: 32 production files, 29 reviewed findings, no suppressions. Addresses #6; follows #14. Stacked on #15, with `codex/issues-10-11-diagnostics` as the base so this review contains only #6. Retarget to main after #15 merges. Commit: `9980373bf6d7025f23560f47ede1c9ff74dce1e1`. This is pushed for review, not merged, release-image-published or deployed. Native ARM64/full release CI and a real-library pilot are not claimed. A separate existing header extends 3px beyond 320px; the report fits and the established whole-page 390px check passes. Keep #6 open through review and the coordinated idle deployment/new owner preview; do not interrupt active uploads/tasks.

jchapman added 1 commit 2026-10-25 21:09:42 +00:00

Explain preliminary metadata coverage separately from ZIP integrity 9980373bf6

jchapman referenced this pull request 2026-10-25 21:09:58 +00:00

Explain metadata matching coverage without presenting it as archive health or predicted import success #6

jchapman referenced this pull request 2026-10-26 23:41:39 +00:00

Add opt-in task emails and routable result pages #20

jchapman referenced this pull request 2026-10-26 23:44:14 +00:00

Add opt-in milestone and failure emails for background tasks #9

jchapman referenced this pull request 2026-10-27 02:06:17 +00:00

Approved pilot priorities and cross-chat handoff workflow #14

jchapman added 6 commits 2026-10-27 02:13:32 +00:00

Keep local recovery available during OIDC discovery failures b84688d2b6

Show truthful task activity and confirm server-task cancellation e980c3778a

Merge pull request #15: Preserve complete private importer logs and flag review concerns ... 15993b0c7c

Integrated after local AMD64 review and validation of the combined PR stack: backend tests/vet/races, UI lint/build/browser, Docker isolation, synthetic upload/recovery and HTTPS smoke, source security policies and secret scan. Existing native Forgejo release gates remain unchanged and are not claimed passed. No deployment. See coordination issue #14.

Merge pull request #16: Keep local recovery available during OIDC failures ... fc14673089

Integrated after local AMD64 review and validation of the combined PR stack: backend tests/vet/races, UI lint/build/browser, Docker isolation, synthetic upload/recovery and HTTPS smoke, source security policies and secret scan. Existing native Forgejo release gates remain unchanged and are not claimed passed. No deployment. See coordination issue #14.

Merge pull request #17: Show truthful task activity and confirm server-task cancellation ... 82307417a9

Integrated after local AMD64 review and validation of the combined PR stack: backend tests/vet/races, UI lint/build/browser, Docker isolation, synthetic upload/recovery and HTTPS smoke, source security policies and secret scan. Existing native Forgejo release gates remain unchanged and are not claimed passed. No deployment. See coordination issue #14.

Merge main into metadata coverage and preserve task cancellation 3cc5c33616

jchapman changed target branch from codex/issues-10-11-diagnostics to main 2026-10-27 02:13:40 +00:00

jchapman merged commit 4de3f35f20 into main 2026-10-27 02:13:41 +00:00

jchapman referenced this pull request from a commit 2026-10-27 02:13:43 +00:00

Merge pull request #18: Explain preliminary metadata coverage separately from ZIP integrity

jchapman referenced this pull request 2026-10-27 02:18:47 +00:00

Approved pilot priorities and cross-chat handoff workflow #14

jchapman referenced this pull request 2026-10-27 02:18:48 +00:00

Explain metadata matching coverage without presenting it as archive health or predicted import success #6

jchapman referenced this pull request 2026-10-27 02:29:09 +00:00

Explain metadata matching coverage without presenting it as archive health or predicted import success #6

jchapman referenced this pull request 2026-10-27 02:29:34 +00:00

Approved pilot priorities and cross-chat handoff workflow #14

Sign in to join this conversation.

Reviewers

No reviewers

Labels

Clear labels

No items

No labels

Milestone

Clear milestone

No items

No milestone

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

1 participant

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference

jchapman/Immich-Bridge!18

No description provided.